[PATCH] D31830: Emit invariant.group.barrier when using union field
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun May 28 15:43:14 PDT 2017
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Looks great, thanks. One request for additional tests, but feel free to commit when that's ready.
Comment at: test/CodeGenCXX/strict-vtable-pointers.cpp:258
Please include test cases involving classes that only have a virtual pointer in a field of a base class — e.g. something that inherits from HoldingVirtuals. And be sure to cover both normal and virtual inheritance.
More information about the cfe-commits