[PATCH] D33437: Emit available_externally vtables opportunistically

Piotr Padlewski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 27 03:46:08 PDT 2017

Prazek added a comment.

Thanks for the comments :)

Comment at: include/clang/AST/VTableBuilder.h:160
+           "GlobalDecl can be created only from virtual function");
+    if (getKind() == CK_FunctionPointer)
+      return GlobalDecl(getFunctionDecl());
rjmccall wrote:
> Please use an exhaustive switch.  You can put llvm_unreachable in the other cases.
Should I implement this for RTTI fields? Or maybe leave a fixme comment that it could also work for some other fields in vtable, but is not currently used?


More information about the cfe-commits mailing list