[PATCH] D33082: Fix Libc++ build with MinGW64

Ben Craig via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 25 18:47:31 PDT 2017


bcraig added a comment.

> Are you suggesting that libc++ should stop declaring/defining these functions, at least publically?

I think that we generally shouldn't be giving functions names that are already claimed elsewhere (like mbsnrtowcs and wcsnrtombs).  It is my opinion that these should always be qualified as __libcpp_* symbols.  We can easily run into trouble if users also defined mbsnrtowcs.  They have just as much of a right to do so as we do.

That being said, I think that's a change for a different changelist.


https://reviews.llvm.org/D33082





More information about the cfe-commits mailing list