[PATCH] D33340: [libcxx] [test] Add string nullptr asserts to erase functions.

Billy Robert O'Neal III via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 25 12:03:05 PDT 2017

BillyONeal closed this revision.
BillyONeal added a comment.

In https://reviews.llvm.org/D33340#764206, @EricWF wrote:

> Sorry for the delay reviewing such a simple change.

No problem! Their simplicity also means no likely merge conflicts :)

In https://reviews.llvm.org/D33340#764213, @EricWF wrote:

> @BillyONeal Changes like this are good for post-commit review (ie just commit it). Adding clearly correct assertions and test cases is never an objectionable thing.

Sounds good, thanks!


More information about the cfe-commits mailing list