[PATCH] D30837: [libcxx] Support for shared_ptr<T()>

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 25 00:18:33 PDT 2017


EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

LGTM after addressing inline comments. Sorry for the delay.



================
Comment at: include/memory:3663
+    template <class _Other>
+    struct rebind
+    {
----------------
This rebind isn't getting selected because it's private, but `std::allocator_traits` is doing the rebinding instead.

Please make the rebinding public.


https://reviews.llvm.org/D30837





More information about the cfe-commits mailing list