[PATCH] D33532: [coroutines] Fix fallthrough diagnostics for coroutines
Eric Fiselier via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 24 18:34:22 PDT 2017
EricWF created this revision.
This patch fixes a number of issues with the analysis warnings emitted when a coroutine may reach the end of the function w/o returning.
- Fix bug where coroutines with `return_value` are incorrectly diagnosed as missing `co_return`'s.
- Rework diagnostic message to no longer say "non-void coroutine", because that implies the coroutine doesn't have a void return type, which it might. In this case a non-void coroutine is one who's promise type does not contain `return_void()`
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 11454 bytes
Desc: not available
More information about the cfe-commits