[PATCH] D33448: [CodeGen] Add thumb-mode to function target-features for arm/thumb triples.

[Florian Hahn via Phabricator via cfe-commits]

fhahn added a comment.

In https://reviews.llvm.org/D33448#762410, @echristo wrote:

> I probably would have added this as a feature in ARMTargetInfo similar to CRC/soft-float/etc.
>
> Thoughts?


Do you mean ARMTargetMachine::getSubtargetImpl (https://github.com/llvm-mirror/llvm/blob/master/lib/Target/ARM/ARMTargetMachine.cpp#L305) ?

It seems like that function is only used by llc (and not llvm-as for example) and at that stage it is too late to add thumb-mode, because llc operates on a single module with a single target triple.


https://reviews.llvm.org/D33448