[PATCH] D33440: clang-format: properly handle Q_UNUSED and QT_REQUIRE_VERSION

Daniel Jasper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 24 05:53:32 PDT 2017

djasper added a comment.

I generally would not be opposed to such a patch. However, note that this might be hard to get right. We had significant performance problems in the past with ForEachMacros as we used to match every single identifier against the regex stored in there. For for loops you can somewhat get out of that and you might be able to do the same thing here, but I am not entirely sure. In contrast, the added value is actually not very large. clang-format is merely not able to automatically fix something to your liking and it's very easy to make the code right and have clang-format keep it that way.


More information about the cfe-commits mailing list