[PATCH] D33483: [OpenCL] reserve_id_t cannot be used as argument to kernel function

Egor Churaev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 24 01:01:09 PDT 2017

echuraev created this revision.
Herald added a subscriber: yaxunl.



Index: test/SemaOpenCL/invalid-pipes-cl2.0.cl
--- test/SemaOpenCL/invalid-pipes-cl2.0.cl
+++ test/SemaOpenCL/invalid-pipes-cl2.0.cl
@@ -3,6 +3,11 @@
 global pipe int gp;            // expected-error {{type '__global read_only pipe int' can only be used as a function parameter in OpenCL}}
 global reserve_id_t rid;          // expected-error {{the '__global reserve_id_t' type cannot be used to declare a program scope variable}}
+extern pipe write_only int get_pipe(); // expected-error {{type '__global write_only pipe int ()' can only be used as a function parameter in OpenCL}}
+kernel void test_invalid_reserved_id(reserve_id_t ID) { // expected-error {{'reserve_id_t' cannot be used as the type of a kernel parameter}}
 void test1(pipe int *p) {// expected-error {{pipes packet types cannot be of reference type}}
 void test2(pipe p) {// expected-error {{missing actual type specifier for pipe}}
Index: lib/Sema/SemaDecl.cpp
--- lib/Sema/SemaDecl.cpp
+++ lib/Sema/SemaDecl.cpp
@@ -7917,10 +7917,7 @@
   if (PT->isImageType())
     return PtrKernelParam;
-  if (PT->isBooleanType())
-    return InvalidKernelParam;
-  if (PT->isEventT())
+  if (PT->isBooleanType() || PT->isEventT() || PT->isReserveIDT())
     return InvalidKernelParam;
   // OpenCL extension spec v1.2 s9.5:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D33483.100048.patch
Type: text/x-patch
Size: 1436 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170524/af98924d/attachment.bin>

More information about the cfe-commits mailing list