[PATCH] D32449: Modifying PthreadLockChecker.cpp to reduce false positives.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 23 09:01:07 PDT 2017

NoQ added a comment.

No-no, all i was trying to say is that there's code in `PthreadLockChecker.cpp` that you haven't changed, but accidentally reformatted - and this is something we normally try to avoid. Like, for example, changing `enum LockingSemantics {...}` from vertical to horizontal - that wasn't your intention, it just accidentally happened because you auto-reformatted the whole file. I don't mind these changes, and i didn't mean they introduce any merge conflicts for now, though they tend to do so in the future for other people working on the same code, as we have a few downstream users, and magenta guys who are working on this checker as part of https://reviews.llvm.org/D26342), so most of the time it's better not to introduce unnecessary changes.

I'm not sure if you can easily revert the style-only changes via `git clang-format`, but you should be able to find them with the help of `git reflog` if you made a local commit before running clang-format (even if it was later discarded or amended), otherwise only manually i guess.



More information about the cfe-commits mailing list