[PATCH] D33395: [clangd] Split clangd into library+executable (mainly for unit tests).

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.


================
Comment at: clangd/tool/ClangdMain.cpp:11
+#include "../ClangdLSPServer.h"
+#include "../JSONRPCDispatcher.h"
 #include "llvm/Support/CommandLine.h"
----------------
krasimir wrote:
> I'd suggest to not have parent directory includes, but add them to the cmake file as in other extra tools, like in:
> https://github.com/llvm-mirror/clang-tools-extra/blob/master/clang-query/tool/CMakeLists.txt
Done. I've actually followed a pattern of CMakeLists.txt from tool-extra, albeit a different one :-)
https://github.com/llvm-mirror/clang-tools-extra/blob/master/clang-tidy/tool/ClangTidyMain.cpp


https://reviews.llvm.org/D33395