[PATCH] D33272: Method loadFromCommandLine should be able to report errors

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 22 06:31:21 PDT 2017

alexfh added inline comments.

Comment at: lib/Tooling/CompilationDatabase.cpp:164
+    // to user.
+    } else if (DiagLevel >= DiagnosticsEngine::Error)
+      Other.HandleDiagnostic(DiagLevel, Info);
Another couple of nits:
1. the comment below would probably be better moved to the body of the second `if`
2. enclose the next statement in braces.


More information about the cfe-commits mailing list