[PATCH] D33356: [Nios2] Changes in frontend to support Nios2 LLVM target

[Joerg Sonnenberger via Phabricator via cfe-commits]

joerg added inline comments.


================
Comment at: lib/Basic/Targets.cpp:7614
+      resetDataLayout(("e-" + Layout).str());
+    }
+  }
----------------
Can you just give the full string and avoid the runtime allocations?


================
Comment at: lib/Basic/Targets.cpp:7650
+    DefineStd(Builder, "nios2", Opts);
+    DefineStd(Builder, "NIOS2", Opts);
+
----------------
DefineStd tends to give a lot of namespace pollution, is that intentional here?


https://reviews.llvm.org/D33356