[PATCH] D33314: clang-format: Add option to remove semicolon at end of namespace

Daniel Jasper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 18 23:31:21 PDT 2017


djasper added a comment.

Yes, this definitely does not belong in the NamespaceEndCommentsFixer. It has nothing to do with comments.

And I am also very skeptical about several things:

- Why start here? There are many places where semicolons could be cleaned up.
- If we add more of such cleanup functionality, I think we should pull them out of the general configuration. This isn't really part of a "style".
- We do have some somewhat related functionality to cleanup in the Cleaner class in Format.cpp.

Before going forward with this, I'd like to understand what the long-term plan is.


https://reviews.llvm.org/D33314





More information about the cfe-commits mailing list