[PATCH] D33191: [analyzer] ObjCGenerics: account for __kindof specifiers met along a chain of casts.

Anna Zaks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 17 08:59:53 PDT 2017


zaks.anna added inline comments.


================
Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:464
                          ASTContext &C) {
+  if (hasKindofArgs(StaticUpperBound)) {
+    // If the upper bound type has more __kindof specs, we drop all the info,
----------------
I am concerned that this might cause regressions as other logic in this function is not triggered when this condition fires. For example, this would only be safe if Current and StaticUpperBoound are the same type apart from __kindof modifier.


https://reviews.llvm.org/D33191





More information about the cfe-commits mailing list