[PATCH] D32480: [clang-format] Add BinPackNamespaces option

[Daniel Jasper via Phabricator via cfe-commits]

djasper added inline comments.


================
Comment at: include/clang/Format/Format.h:153
+  /// \endcode
+  bool AllowSemicolonAfterNamespace;
+
----------------
While I am not entirely opposed to this feature, I think it should be a separate patch.


================
Comment at: include/clang/Format/Format.h:358
+  /// \endcode
+  bool BinPackNamespaces;
+
----------------
This is not bin packing at all. Maybe CompactNamespaces? Or SingleLineNamespaces?

Also, could you clarify what happens if the namespaces don't fit within the column limit (both in the comment describing the flag and by adding tests for it)?


https://reviews.llvm.org/D32480