[PATCH] D33209: [clang-tidy] Add "emplace_back" detection in inefficient-vector-operation.

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 16 00:15:05 PDT 2017


alexfh added inline comments.


================
Comment at: clang-tidy/performance/InefficientVectorOperationCheck.cpp:208
+           "consider pre-allocating the vector capacity before the loop")
+      << VectorAppendCall->getMethodDecl()->getDeclName();
 
----------------
Diagnostic builder should be able to format NamedDecls directly, this `->getDeclName()` is not necessary. The only difference is that it will likely add quotes around the name, which seems to be good anyway.


Repository:
  rL LLVM

https://reviews.llvm.org/D33209





More information about the cfe-commits mailing list