[PATCH] D32248: CodeGen: Cast alloca to expected address space

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 15 14:37:02 PDT 2017


rjmccall added a comment.

Looking good.  We had some overlapping patches and comments there, so I want to make sure you didn't miss my comment on EmitAutoVarAlloca.



================
Comment at: lib/Sema/SemaDecl.cpp:7205
+    }
+    assert (T.getAddressSpace() != LangAS::opencl_constant);
+    if (T.getAddressSpace() == LangAS::opencl_global) {
----------------
LLVM code style doesn't put a space after assert.


https://reviews.llvm.org/D32248





More information about the cfe-commits mailing list