[PATCH] D33010: Make google-build-using-namespace skip std::.*literals

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 15 06:25:01 PDT 2017


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

LG with one nit. Thank you for addressing this! Do you need me to commit the patch for you?



================
Comment at: clang-tidy/google/UsingNamespaceDirectiveCheck.cpp:48
 
+bool UsingNamespaceDirectiveCheck::isStdLiteralsNamespace(
+    const NamespaceDecl *NS) {
----------------
Please make this a static free function instead, since it doesn't need access to the check's members.


https://reviews.llvm.org/D33010





More information about the cfe-commits mailing list