[PATCH] D33082: Fix Libc++ build with MinGW64
Shoaib Meenai via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun May 14 14:32:48 PDT 2017
smeenai added a comment.
In https://reviews.llvm.org/D33082#754451, @compnerd wrote:
> Sure, a `_LIBCPP_MSVCRT_LIKE` WFM. I just want to make sure that we don''t conflate the underlying libc implementation with the Win32 API set.
Yup, that was my concern as well.
In https://reviews.llvm.org/D33082#754262, @mati865 wrote:
> I don't know if it is MSYS2 specific or general MinGW issue but liblibc++.a is created. Could you check your build?
> Here is line to blame: https://github.com/llvm-mirror/libcxx/blob/master/lib/CMakeLists.txt#L246
Sounds like a cmake prefix issue. We should be able to fix this by unconditionally setting `CMAKE_STATIC_LIBRARY_PREFIX` to `lib` instead of changing the output name, I think.
More information about the cfe-commits