[PATCH] D33082: Fix Libc++ build with MinGW64

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun May 14 12:48:29 PDT 2017

smeenai added a comment.

@compnerd see my previous comment:

> @EricWF and I discussed this on IRC a bit. I'm not a fan of overloading _LIBCPP_WIN32API for this purpose, since to me that macro is meant for guarding Windows API functions, not for CRT functions. Eric suggested adding a new macro _LIBCPP_MSVCRT_LIKE, which I'd be fine with.

`_LIBCPP_MSVCRT` isn't defined for MinGW (since they have their own CRT headers), so we need a new macro that's defined for both MSVCRT and MinGW.


More information about the cfe-commits mailing list