[PATCH] D33080: [Libc++] Use #pragma push_macro/pop_macro to better handle min/max on Windows

Saleem Abdulrasool via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun May 14 12:38:05 PDT 2017

compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.

I think that we should sink the `min`/`max` checks into `__undef_macros`.  I don't like the idea of littering that check everywhere.

Comment at: include/__config:1218
+# if defined(_LIBCPP_COMPILER_MSVC)
+#   define _LIBCPP_PUSH_MACROS  \
+      __pragma(push_macro("min")) \
clang-format these please?  It does a nice job of aligning the `\`.


More information about the cfe-commits mailing list