[PATCH] D33082: Fix Libc++ build with MinGW64

Ben Craig via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 11 08:26:09 PDT 2017

bcraig added a comment.

I agree that we need to be precise in our platform detection macros.  On Windows, we currently need to worry about which compiler is being used, whether we are targeting the mingw environment or the native (?) environment, and which c-runtime is being used.

For my msvc-kernel work, I'll need some amount of platform detection macros as well (I'm not expecting those to be added in this review).  I believe I will represent that with some combination of a "freestanding" macro, a different name for the CRT, and detection of the MSVC compiler, but I haven't gotten that far yet.


More information about the cfe-commits mailing list