[PATCH] D33030: [libcxxabi] Align unwindHeader on a double-word boundary
Mehdi AMINI via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 10 17:13:37 PDT 2017
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D33030#751723, @ahatanak wrote:
> If field unwindHeader is annotated with the aligned attribute, both the field and struct __cxa_exception are aligned. As a result, the exception object that follows __cxa_exception is aligned too.
> If we annotate struct __cxa_exception with the attribute instead of annotating the field, the test case segfaults. It seems that this approach doesn't work because several places in cxa_exception.cpp assume the exception object immediately follows field unwindHeader (there are should be no paddings at the end of __cxa_exception).
OK, then LGTM but add all these informations as a comment for unwindHeader field.
More information about the cfe-commits