[PATCH] D33021: [libcxx] [test] libc++ test changes for CWG 2094

Marshall Clow via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 10 06:15:35 PDT 2017

mclow.lists added a comment.

In general, I prefer having the space between `static_assert(` and the condition.

That makes it easy (at least for me) to see if there's a `!` there or not.
Other than that, this LGTM.

FWIW, I think this is a language change that core got wrong, and it has already come back to bite us. (https://bugs.llvm.org/show_bug.cgi?id=28527)


More information about the cfe-commits mailing list