[PATCH] D32437: [analyzer] Nullability: fix a crash when adding notes inside a synthesized property accessor.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 9 23:40:37 PDT 2017

NoQ added a comment.

> What are these? Is there a PR?

The best explanation we currently have, with examples, is https://reviews.llvm.org/D24278

> It would be great if we could place a note on a parent that has location.

That's actually the best approach in my opinion, if achievable.

> For example, can we walk up the location context?

That wouldn't work this way because we'd have the completely redundant "calling property accessor" piece before that, and "returning..." after that. Instead, i guess i'd try to actually report a note either before entering the call or after returning from the call, so that call enter notes get pruned for having nothing in between.


More information about the cfe-commits mailing list