[PATCH] D32724: [Modules] Handle sanitizer feature mismatches when importing modules

Adrian Prantl via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 9 16:51:58 PDT 2017

aprantl added inline comments.

Comment at: include/clang/Basic/Sanitizers.h:64
-  /// \brief Disable all sanitizers.
-  void clear() { Mask = 0; }
+  /// \brief Disable the sanitizers specified in \p K (by default, disable
+  /// all sanitizers).
Might as well delete the `\brief` while you are modifying the comment.

Comment at: include/clang/Basic/Sanitizers.h:85
+/// AST generation.
+static inline SanitizerMask getModularSanitizers() {
+  return SanitizerKind::CFI | SanitizerKind::Integer |
getModularSanitizers is a bit misleading. How about `getASTTransparentSanitizers` or something along those lines?


More information about the cfe-commits mailing list