[PATCH] D32972: [index] Index simple dependent declaration references

Ben Langmuir via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 9 09:29:47 PDT 2017

benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.

A couple of minor comments, but otherwise LGTM.

Comment at: include/clang/AST/DeclCXX.h:1569
+  bool lookupInBases(BaseMatchesCallback BaseMatches, CXXBasePaths &Paths,
+                     bool LookupInDependent = false) const;
Since the other params are documented above, this should be too.

Comment at: lib/AST/CXXInheritance.cpp:281
+        }
+      } else
+        BaseRecord = cast<CXXRecordDecl>(
Please put `{}` around this else.  The first two times I read this I thought the following if was nested inside this else.



More information about the cfe-commits mailing list