[PATCH] D32751: [ASTImporter] Support new kinds of declarations (mostly Using*)

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun added a comment.

Looks good for me, I only have a few questions. Could you reupload the diff with contexts? It might make the review easier for others.



================
Comment at: lib/AST/ASTImporter.cpp:1311
+  EmptyDecl *ToD = EmptyDecl::Create(Importer.getToContext(), DC, Loc);
+  ToD->setLexicalDeclContext(LexicalDC);
+  LexicalDC->addDeclInternal(ToD);
----------------
Don't we need an Importer.Imported call here? 


================
Comment at: lib/AST/ASTImporter.cpp:1461
+
+  // NOTE: No any conflict resolution is done for namespace aliases.
+
----------------
Minor nit: do we need the any in this sentence?


https://reviews.llvm.org/D32751