[PATCH] D32248: CodeGen: Cast alloca to expected address space

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked 2 inline comments as done.
yaxunl added inline comments.


================
Comment at: test/CodeGenCXX/amdgcn-automatic-variable.cpp:25
+  // CHECK: store i32 2, i32* %[[r1]]
+  int lv1;
+  lv1 = 1;
----------------
yaxunl wrote:
> Anastasia wrote:
> > I am wondering if all these different test cases are really needed. Are we testing any different program paths from the patch?
> > 
> > Also would it make sense to add a test case with an object in an AS different to 0 (i.e. with `__attribute__((address_space(n)))`)
> I think at least I should cover the typical use cases of auto var.
> 
> I will add a test for __attribute__((address_space(n))))
Sorry. I just checked that C++ does not allow __attribute__((address_space(n))) on automatic var.


https://reviews.llvm.org/D32248