[PATCH] D32759: Fix errored return value in CheckFunctionReturnType and add a fixit hint

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 8 12:18:56 PDT 2017


efriedma added a comment.

In https://reviews.llvm.org/D32759#748653, @chenwj wrote:

> In https://reviews.llvm.org/D32759#748007, @efriedma wrote:
>
> > The difference between returning true and false here is just the way error recovery works: when we return true, we know the type is invalid, so we suppress it, and subsequent errors involving the declaration.  Example (Objective-C++) where we currently print two errors:
>
>
> So when we see `T->isObjCObjectType()` is true, then we should return true since the return type is invalid?


Yes.


https://reviews.llvm.org/D32759





More information about the cfe-commits mailing list