[PATCH] D32927: [libc++] Implement exception_ptr on Windows

Ben Craig via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun May 7 18:20:44 PDT 2017


bcraig added a comment.

Getting the test suite green sooner rather than later seems like a good reason to temporarily pick a 1-3 year solution rather than a 5+ year solution.  Also, as you mention, this isn't all throw away work, so it's still progress.

So yeah, this is fine to go in as is.  LGTM.


https://reviews.llvm.org/D32927





More information about the cfe-commits mailing list