[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

Jonas Hahnfeld via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 4 10:39:12 PDT 2017


Hahnfeld added a comment.

One minor drive-by comment. I think there is still one outstanding from Justin...



================
Comment at: lib/Driver/ToolChains/Cuda.cpp:368
+  assert(!GpuArch.empty() && "Must have an explicit GPU arch.");
+  std::string LibDeviceFile;
 
----------------
You can move the declaration down to the initialization


Repository:
  rL LLVM

https://reviews.llvm.org/D29647





More information about the cfe-commits mailing list