[PATCH] D32767: [clang-tidy] Fix PR32896: detect initializer lists in modernize-use-empalce

[Jakub Kuderski via Phabricator via cfe-commits]

kuhar added inline comments.


================
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:23
 
+AST_MATCHER(CXXStdInitializerListExpr, cxxStdInitializerListExpr) {
+  return true;
----------------
Prazek wrote:
> kuhar wrote:
> > alexfh wrote:
> > > This should be a node matcher rather than a narrowing matcher, and it should be placed to ASTMatchers.h, if there is no such matcher already.
> > I wanted to backport this fix to 4.0.1 release after applying it in trunk.
> > I thought that adding a new ASTMatcher would introduce an API change in clang, and I'm not sure if it's much welcome.
> > 
> > Maybe it would be better to introduce a new matcher in ASTMatchers.h in trunk and make it an internal narrowing matcher in the backported patch? What would be best?  
> Why adding new matcher to 4.0.1 release is bad? Will it break anything?
The example that I originally came up with was updating clang-tidy to 4.0.1 while keeping clang libs 4.0.0, but since we just include all the matchers I think it should work fine.

Here's a patch with the new matcher: https://reviews.llvm.org/D32810


https://reviews.llvm.org/D32767