r301732 - Remove some apparently-unnecessary 'REQUIRES: system-darwin' from tests.

[Vitaly Buka via cfe-commits]

We should file a bug and disable the test. Red bots are inconvenient for
build cop.
I have not notice this on non-asan builds, but I didn't look.

On Mon, May 1, 2017 at 12:14 PM Richard Smith <richard at metafoo.co.uk> wrote:

> Looks like this test has found a bug in the compiler. I've not repro'd it
> yet but my guess is that we're hitting an asan error while attempting to
> build the preprocessed source. We can temporarily disable this test to get
> the bot green again if you like. Have you noticed it failing for non-asan'd
> builds of clang?
>
> On 1 May 2017 at 10:54, Vitaly Buka <vitalybuka at google.com> wrote:
>
>>
>> crash-vfs-ivfsoverlay.m does not work
>>
>>
>> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1322/steps/check-clang%20asan/logs/stdio
>>
>>
>> On Fri, Apr 28, 2017 at 6:51 PM Richard Smith via cfe-commits <
>> cfe-commits at lists.llvm.org> wrote:
>>
>>> Author: rsmith
>>> Date: Fri Apr 28 20:38:29 2017
>>> New Revision: 301732
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=301732&view=rev
>>> Log:
>>> Remove some apparently-unnecessary 'REQUIRES: system-darwin' from tests.
>>>
>>> Let's see if any buildbots actually have trouble with these. (They at
>>> least pass on Linux.)
>>>
>>> Modified:
>>>     cfe/trunk/test/Modules/crash-vfs-headermaps.m
>>>     cfe/trunk/test/Modules/crash-vfs-include-pch.m
>>>     cfe/trunk/test/Modules/crash-vfs-ivfsoverlay.m
>>>
>>> Modified: cfe/trunk/test/Modules/crash-vfs-headermaps.m
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Modules/crash-vfs-headermaps.m?rev=301732&r1=301731&r2=301732&view=diff
>>>
>>> ==============================================================================
>>> --- cfe/trunk/test/Modules/crash-vfs-headermaps.m (original)
>>> +++ cfe/trunk/test/Modules/crash-vfs-headermaps.m Fri Apr 28 20:38:29
>>> 2017
>>> @@ -1,4 +1,4 @@
>>> -// REQUIRES: crash-recovery, shell, system-darwin
>>> +// REQUIRES: crash-recovery, shell
>>>
>>>  // This uses a headermap with this entry:
>>>  //   Foo.h -> Foo/Foo.h
>>>
>>> Modified: cfe/trunk/test/Modules/crash-vfs-include-pch.m
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Modules/crash-vfs-include-pch.m?rev=301732&r1=301731&r2=301732&view=diff
>>>
>>> ==============================================================================
>>> --- cfe/trunk/test/Modules/crash-vfs-include-pch.m (original)
>>> +++ cfe/trunk/test/Modules/crash-vfs-include-pch.m Fri Apr 28 20:38:29
>>> 2017
>>> @@ -1,4 +1,4 @@
>>> -// REQUIRES: crash-recovery, shell, system-darwin
>>> +// REQUIRES: crash-recovery, shell
>>>  //
>>>  // RUN: rm -rf %t
>>>  // RUN: mkdir -p %t/m %t/out
>>>
>>> Modified: cfe/trunk/test/Modules/crash-vfs-ivfsoverlay.m
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Modules/crash-vfs-ivfsoverlay.m?rev=301732&r1=301731&r2=301732&view=diff
>>>
>>> ==============================================================================
>>> --- cfe/trunk/test/Modules/crash-vfs-ivfsoverlay.m (original)
>>> +++ cfe/trunk/test/Modules/crash-vfs-ivfsoverlay.m Fri Apr 28 20:38:29
>>> 2017
>>> @@ -1,4 +1,4 @@
>>> -// REQUIRES: crash-recovery, shell, system-darwin
>>> +// REQUIRES: crash-recovery, shell
>>>
>>>  // RUN: rm -rf %t
>>>  // RUN: mkdir -p %t/m
>>>
>>>
>>> _______________________________________________
>>> cfe-commits mailing list
>>> cfe-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170501/267c449d/attachment.html>