[PATCH] D32646: Fix a bug that -Wmissing-braces fires on system headers

Rui Ueyama via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 28 08:13:14 PDT 2017


ruiu added inline comments.


================
Comment at: test/Sema/warn-missing-braces.c:6-11
+typedef struct _GUID {
+  unsigned Data1;
+  unsigned short  Data2;
+  unsigned short  Data3;
+  unsigned char Data4[8];
+} GUID;
----------------
You can simplify this, can't you? It seems something like

  struct foo { unsigned data[2]; };

suffices.


================
Comment at: test/Sema/warn-missing-braces.c:22
+
+GUID g = REGISTRY_EXTENSION_GUID; // should not show warnings
+
----------------
So this can be something like `struct foo b = BAR;`


https://reviews.llvm.org/D32646





More information about the cfe-commits mailing list