[PATCH] D32603: Build the Apple-style stage2 with modules and full debug info

[Chris Bieneman via Phabricator via cfe-commits]

beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.

SWEET! this is great to see! One small comment inline, otherwise LGTM.



================
Comment at: cmake/caches/Apple-stage2.cmake:33
+set(CMAKE_C_FLAGS_RELWITHDEBINFO "-O2 -g -DNDEBUG" CACHE STRING "")
+set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O2 -g -DNDEBUG" CACHE STRING "")
 set(CMAKE_BUILD_TYPE RelWithDebInfo CACHE STRING "")
----------------
Alternatively you can just remove these two lines because you're just setting this to the default value. It was only overridden to set line-tables-only.


Repository:
  rL LLVM

https://reviews.llvm.org/D32603