[PATCH] D32499: Further delay calling DeclMustBeEmitted until it's safe.

Raphael Isemann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 25 11:10:06 PDT 2017


teemperor created this revision.

As discussed in https://reviews.llvm.org/D30793, we have some unsafe calls to `isConsumerInterestedIn()`. This patch implements Richard's suggestion (from the inline comment) that we should track if we just deserialized an declaration. If we just deserialized, we can skip the unsafe call because we know it's interesting. If we didn't just deserialize the declaration, calling `isConsumerInterestedIn()` should be safe.


https://reviews.llvm.org/D32499

Files:
  include/clang/Serialization/ASTReader.h
  lib/Serialization/ASTReader.cpp
  lib/Serialization/ASTReaderDecl.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32499.96606.patch
Type: text/x-patch
Size: 4763 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170425/ecad1208/attachment.bin>


More information about the cfe-commits mailing list