[PATCH] D32456: [ubsan] Make the alignment check work with some extern decls (PR32630)

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 24 17:20:35 PDT 2017


efriedma added a comment.

> Note: it would still not be able to catch the following case --

Do you know why?



================
Comment at: lib/CodeGen/CodeGenModule.cpp:2319
+      // The alignment sanitizer can catch more bugs if we don't attach
+      // alignment info to extern globals.
+    } else {
----------------
If we don't explicitly set the alignment, is it 1?  Or is it picking up the alignment from the type somehow?


https://reviews.llvm.org/D32456





More information about the cfe-commits mailing list