[PATCH] D32371: Add comments to the diagnostic kinds in Diagnostic.td.

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 21 14:05:07 PDT 2017


hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

Highly useful I'd say!

lgtm



================
Comment at: include/clang/Basic/Diagnostic.td:113
+// Extensions are warnings about accepted language extensions that are
+// default-off but enabled by -pedantic.
 class Extension<string str> : Diagnostic<str, CLASS_EXTENSION, SEV_Ignored>;
----------------
Nit: On first glance, one might parse this as the accepted language extensions being enabled by -pedantic, not the warnings. Maybe spell it out: "about accepted language extensions. The warnings are default-off bug enabled by -pedantic."


https://reviews.llvm.org/D32371





More information about the cfe-commits mailing list