[PATCH] D32342: Fixed llvm/CMakeLists.txt which doesn't generate proper MakeFiles and added relative path to llvm doxygen

Yuka Takahashi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 21 01:43:11 PDT 2017


yamaguchi created this revision.
Herald added a subscriber: mgorny.

Fist part is to change CMakeLists.txt and doxygen.cfg.in by following reasons:
In llvm/docs/CmakeLists.txt, it was

- set(abs_top_srcdir ${LLVM_MAIN_SRC_DIR})
- set(abs_top_builddir ${LLVM_BINARY_DIR})

However, ${LLVM_MAIN_SRC_DIR} is not an environmental variable but  just a normal local PATH, which is substituted by llvm/CmakeLists.txt as follows:

297 set(LLVM_MAIN_SRC_DIR     ${CMAKE_CURRENT_SOURCE_DIR}  ) # --src-root                                                                
298 set(LLVM_MAIN_INCLUDE_DIR ${LLVM_MAIN_SRC_DIR}/include ) # --includedir
299 set(LLVM_BINARY_DIR       ${CMAKE_CURRENT_BINARY_DIR}  ) # --prefix

llvm/docs/CmakeLists.txt will not be substituted by llvm/CMakeLists.txt, so we have to change it to ${CMAKE_CURRENT_FOO_DIR}.
In clang/docs/CmakeLists.txt, ${CMAKE_CURRENT_FOO_DIR} is already properly used, so we don't have to change it.

Also, I added README.txt how to generate llvm doxygen.

Second part is to change #include <Foo.h> to #include "Foo/Foo.h" as we did in clang [1].
It will change #include <jitprofiling.h> to #include "ExecutionEngine/IntelJITEvents/jitprofiling.h"

[1]
https://reviews.llvm.org/D32113


https://reviews.llvm.org/D32342

Files:
  docs/CMakeLists.txt
  docs/README.txt
  docs/doxygen.cfg.in

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32342.96110.patch
Type: text/x-patch
Size: 4407 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170421/1c8dd091/attachment-0001.bin>


More information about the cfe-commits mailing list