[libcxx] r300944 - update XFAIL comments with more details

Eric Fiselier via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 20 20:09:40 PDT 2017


Author: ericwf
Date: Thu Apr 20 22:09:40 2017
New Revision: 300944

URL: http://llvm.org/viewvc/llvm-project?rev=300944&view=rev
Log:
update XFAIL comments with more details

Modified:
    libcxx/trunk/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp
    libcxx/trunk/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp

Modified: libcxx/trunk/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp?rev=300944&r1=300943&r2=300944&view=diff
==============================================================================
--- libcxx/trunk/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp (original)
+++ libcxx/trunk/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp Thu Apr 20 22:09:40 2017
@@ -7,9 +7,8 @@
 //
 //===----------------------------------------------------------------------===//
 
-// There appears to be a bug in VerifyDiagnosticReporter on Windows that
-// causes -verify to not see the emitted warnings even though they are
-// actually getting omitted.
+// This test fails because diagnose_if doesn't emit all of the diagnostics
+// when -fdelayed-template-parsing is enabled, like it is on Windows.
 // XFAIL: LIBCXX-WINDOWS-FIXME
 
 // REQUIRES: verify-support, diagnose-if-support

Modified: libcxx/trunk/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp?rev=300944&r1=300943&r2=300944&view=diff
==============================================================================
--- libcxx/trunk/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp (original)
+++ libcxx/trunk/test/libcxx/localization/locales/locale.convenience/conversions/conversions.string/ctor_move.pass.cpp Thu Apr 20 22:09:40 2017
@@ -7,8 +7,7 @@
 //
 //===----------------------------------------------------------------------===//
 
-// This test fails because the `from_bytes` call seems to result in a call
-// to 'abort()'
+// 'do_bytes' throws a std::range_error unexpectedly
 // XFAIL: LIBCXX-WINDOWS-FIXME
 
 // UNSUPPORTED: c++98, c++03




More information about the cfe-commits mailing list