[PATCH] D32320: [libc++] Default to vcruntime when targeting MSVC

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 20 16:32:14 PDT 2017


smeenai added inline comments.


================
Comment at: CMakeLists.txt:119
+    set(LIBCXX_CXX_ABI_LIBNAME "vcruntime")
   else()
+    find_path(
----------------
EricWF wrote:
> Nit: I would rather see this be
> ```
> elseif ((NOT LIBCXX_STANDALONE_BUILD OR HAVE_LIBCXXABI) AND
>         IS_DIRECTORY "${LIBCXX_LIBCXXABI_INCLUDES_INTERNAL}")
> ```
> 
> That way we can avoid a level of nesting. 
Sounds good; will change before committing.


https://reviews.llvm.org/D32320





More information about the cfe-commits mailing list