[PATCH] D29659: [OpenMP] Add flag for disabling the default generation of relocatable OpenMP target code for NVIDIA GPUs.

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 20 12:46:38 PDT 2017


ABataev added inline comments.


================
Comment at: lib/Driver/ToolChains/Cuda.cpp:297
+      !Args.hasFlag(options::OPT_fnoopenmp_relocatable_target,
+                    options::OPT_fopenmp_relocatable_target, false))
     CmdArgs.push_back("-c");
----------------
1. Add a comment with the name of the parameter for `false` argument
2. Why not to use this logic:
```
Args.hasFlag(options::OPT_fopenmp_relocatable_target,
                    options::OPT_fnoopenmp_relocatable_target, true)
```
?


Repository:
  rL LLVM

https://reviews.llvm.org/D29659





More information about the cfe-commits mailing list