[PATCH] D31885: Remove TBAA information from LValues representing union members

Krzysztof Parzyszek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 19 10:25:41 PDT 2017


kparzysz added a comment.

In https://reviews.llvm.org/D31885#730038, @hfinkel wrote:

> I'm somewhat concerned that this patch is quadratic in the AST.


I'd be happy to address this, but I'm not sure how.  Memoizing results could be one way, but don't know if that's acceptable.

This location in codegen seems to be the last place where the original C/C++ types are available, in particular the information as to whether a type is a union or not.  Maybe it would be possible to propagate some bit somewhere, but then this patch would become much less localized.


Repository:
  rL LLVM

https://reviews.llvm.org/D31885





More information about the cfe-commits mailing list