[PATCH] D31885: Remove TBAA information from LValues representing union members

Hal Finkel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 18 20:11:26 PDT 2017


hfinkel added a comment.

To be clear, I'm find with disabling union tbaa until we can fix things for real. I'm somewhat concerned that this patch is quadratic in the AST.

FWIW, I tried just setting TBAAPath = true in EmitLValueForField and then returning nullptr from CodeGenTBAA::getTBAAStructTagInfo when BaseQTy->isUnionType() is true. This mostly works, although it does not handle the array case as this patch does. Maybe putting some code in EmitArraySubscriptExpr will also take care of that?


Repository:
  rL LLVM

https://reviews.llvm.org/D31885





More information about the cfe-commits mailing list