[PATCH] D32178: Delete unstable integration tests

Jonathan Roelofs via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 18 10:07:23 PDT 2017


jroelofs created this revision.

These tests are breaking when tested under the upstream 3.8.1 release + the 10.12 / 16C58 sdk. They use headers from the host SDKs, so they are not stable with respect to adding new language features, such as class `@properties`.

Regression tests should not depend at all on the state of the host system. If these tests are still useful, they ought to live somewhere else (test-suite?).


https://reviews.llvm.org/D32178

Files:
  test/Integration/carbon.c
  test/Integration/cocoa-pch.m
  test/Integration/cocoa.m


Index: test/Integration/cocoa.m
===================================================================
--- test/Integration/cocoa.m
+++ test/Integration/cocoa.m
@@ -1,5 +0,0 @@
-// RUN: %clang -arch x86_64 %s -fsyntax-only -Xclang -print-stats
-#ifdef __APPLE__
-#include <Cocoa/Cocoa.h>
-#endif
-
Index: test/Integration/cocoa-pch.m
===================================================================
--- test/Integration/cocoa-pch.m
+++ test/Integration/cocoa-pch.m
@@ -1,7 +0,0 @@
-// RUN: %clang -arch x86_64 -x objective-c-header %s -o %t.h.pch
-// RUN: touch %t.empty.m
-// RUN: %clang -arch x86_64 -fsyntax-only %t.empty.m -include %t.h -Xclang -ast-dump 2>&1 > /dev/null
-#ifdef __APPLE__
-#include <Cocoa/Cocoa.h>
-#endif
-
Index: test/Integration/carbon.c
===================================================================
--- test/Integration/carbon.c
+++ test/Integration/carbon.c
@@ -1,4 +0,0 @@
-// RUN: %clang -fsyntax-only %s
-#ifdef __APPLE__
-#include <Carbon/Carbon.h>
-#endif


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32178.95585.patch
Type: text/x-patch
Size: 994 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170418/96a3fb69/attachment.bin>


More information about the cfe-commits mailing list