[PATCH] D32092: Attribute inline

Richard Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 14 14:03:24 PDT 2017


rsmith added a comment.

>From some very superficial testing, it looks like CL treats `__declspec(inline)` exactly like a synonym for `inline` (it even rejects them both appearing on the same declaration, complaining about a duplicate `inline` specifier). So modeling this as `GNUInlineAttr` is definitely wrong, and this should probably be setting the `inline` flag on the function. But I agree with Aaron: we need some evidence that implementing this in Clang is worthwhile (rather than changing the codebase to use the `inline` keyword instead). We aim to be CL-compatible for common code patterns, not to be 100% compatible with all code that CL accepts.


https://reviews.llvm.org/D32092





More information about the cfe-commits mailing list