[PATCH] D27546: [ASTReader] Sort RawComments before merging

[Richard Smith via Phabricator via cfe-commits]

rsmith added inline comments.


================
Comment at: lib/Serialization/ASTReader.cpp:8487
+    std::sort(Comments.begin(), Comments.end(),
+              BeforeThanCompare<RawComment>(SourceMgr));
     Context.Comments.addDeserializedComments(Comments);
----------------
Does this cause us to deserialize the SLocEntry for every FileID referenced by a RawComment? That would seem pretty bad.


https://reviews.llvm.org/D27546