[PATCH] D31976: Avoid assert when a non-static member function is qualified with __unaligned

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 13 06:45:33 PDT 2017


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

This seems reasonable to me, but you should wait for confirmation before committing (I'm not as familiar with the mangler as others are).



================
Comment at: test/CodeGenCXX/unaligned-duplicated-mangle-name.cpp:16
+void A::foo() // expected-error {{definition with same mangled name as another definition}}
+              // expected-note at -6 {{previous definition is here}}
+{
----------------
Might as well put this note with the declaration rather than using an offset for the message.


https://reviews.llvm.org/D31976





More information about the cfe-commits mailing list